Fix detection of Chromium based browsers in getMaxElementSize #1355
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…m based browsers Fixed reintroduction of bvaughn#807
|
@wuweiweiwu #807 was fixed in an unknown commit, and verified fixed on Mar 26 2018, #807 (comment). The issue is Chromium specific and the fix depends on detection with the isChrome() function. That function stopped working in Chromium 71 and this pull request fixes that. |
|
ok @nifgraup thanks for clarifying |
wuweiweiwu
approved these changes
Jul 25, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes reintroduction of #807.