Add dynamically measured images example #1081
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hm, the live demo looks busted to me :(
Do you see similar broken/overlapping images and text? |
|
Fixed it in the demo, |
bvaughn
reviewed
Apr 22, 2018
docs/Masonry.md
Outdated
|
|
||
| const MasonryComponent = ({ itemsWithSizes }) => { | ||
| // Default sizes help Masonry decide how many images to batch-measure | ||
| const cache = new CellMeasurerCache({ |
There was a problem hiding this comment.
This should not be created within the MasonryComponent component because that would mean it gets recreated each time.
docs/Masonry.md
Outdated
| }); | ||
|
|
||
| // Our masonry layout will use 3 columns with a 10px gutter between | ||
| const cellPositioner = createMasonryCellPositioner({ |
There was a problem hiding this comment.
This should not be created within the MasonryComponent component because that would mean it gets recreated each time.
|
Fixed in docs too. |
|
Ill take a look later when I have time. But so far it looks good! |
|
@wuweiweiwu awesome! Glad to hear that. |
|
Awesome, the demo seems to have been fixed! Thanks for contributing! |
wuweiweiwu
approved these changes
May 11, 2018
|
Great! Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #979
This pull request adds a small demo with masonry and images of unknown size which are measured in runtime.