feat: Migrating Grid.js to getDerivedStateFromProps #1053
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wuweiweiwu
changed the title
This was referenced Apr 10, 2018
Merged
|
@azmenak there is currently 1 test is failing that I will be taking another look at this weekend. Hopefully soon! |
TrySound
requested changes
Apr 28, 2018
source/Grid/Grid.js
Outdated
| } | ||
|
|
||
| // Update scroll offsets if the size or number of cells have changed, invalidating the previous value | ||
| // Update getters. this is a little hacky | ||
| // TODO: move the configure? |
TrySound
approved these changes
Apr 30, 2018
bvaughn
approved these changes
May 6, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
follow up to #1009
especially need eyes on these parts:
https://github.com/bvaughn/react-virtualized/pull/1053/files#diff-43c6f2c20a98e4816031a2f99092ecb4R791
https://github.com/bvaughn/react-virtualized/pull/1053/files#diff-868d04d08bdf53ce86a26e3f8a99bccdR2316
cc @bvaughn