Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added compile step and node module resolution to translucent-blueprint #39

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

Piefayth
Copy link
Contributor

@Piefayth Piefayth commented Feb 3, 2024

Closes #38

bun run build from the translucent-blueprint folder should produce a valid artifact for any platform that supports the node apis now.

I found one limitation WRT imports described here. Essentially, typescript won't transpile import foo from './foo to import foo from './foo.js no matter what you do. Likewise, the node team specifically refuses to allow ./foo style ESM imports. Luckily, Bun can interpret xxx.js as xxx.ts when handling imports, so the simplest solution here is just to use from xxx.js style imports in translucent-blueprint. It sure looks silly, though.

Also fixed up the test I added to be a lil more Bun-idiomatic, since I had to touch it anyway.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fix building for translucent-blueprint
2 participants