Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change argument name #1

Merged

Conversation

mparada
Copy link

@mparada mparada commented May 8, 2023

Fixes TypeError: __init__() got an unexpected keyword argument 'method_whitelist' related to urllib3 v2 update: urllib3/urllib3#2086

@bustawin
Copy link
Owner

Thanks for the PR! Let me check it out over the weekend and reply you back.

@bustawin bustawin self-assigned this May 23, 2023
@bustawin bustawin self-requested a review May 28, 2023 17:24
* Fix change related to urllib3 v2: urllib3/urllib3#2086
* Set minimum urllib3 dependency
* Bump version to 2.0.0
@bustawin bustawin force-pushed the bugfix/fix-related-to-urllib3-update branch from 92d0925 to 543ceaf Compare May 28, 2023 18:24
@bustawin bustawin merged commit 543ceaf into bustawin:master May 28, 2023
@bustawin
Copy link
Owner

@mparada I added a test and uploaded an update—version 2.0.0. Thanks again ;-)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants