Implement equals/hashcode for RequestOptions and TransitionOptions #4917
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ncrete classes. It's a little tricky to get this right because we've defined equals/hashcode in the base classes, but are implementing them in the concrete classes. I think this implementation is actually safe because the base classes are abstract. However making equals transitive requires the weird equals() only implementations in the classes that have no properties but are concrete implementations of the base classes. A safer way to do this would be to move the the equals/hashcode implementation out of the base class and re-implement it in each subclass. However that would require exposing a bunch of internal instance variables to subclasses. Given the existing structure and the public nature of the base classes, this seems like a reasonable compromise. Fixes bumptech#4916
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It's a little tricky to get this right because we've defined equals/hashcode in the base classes, but are implementing them in the concrete classes. I think this implementation is actually safe because the base classes are abstract. However making equals transitive requires the weird equals() only implementations in the classes that have no properties but are concrete implementations of the base classes.
A safer way to do this would be to move the the equals/hashcode implementation out of the base class and re-implement it in each subclass. However that would require exposing a bunch of internal instance variables to subclasses. Given the existing structure and the public nature of the base classes, this seems like a reasonable compromise.
Fixes #4916