Skip to content

Commit

Permalink
Compose Bugfix: If requestBuilder has not changed, the requestState, …
Browse files Browse the repository at this point in the history
…painter(State) and requestListener should not change either. Otherwise, the GlideImage will display nothing or loadingPainter. Since requestState will be reset to RequestState.Loading and GlideNode.launchRequest will not run due to requestBuilder not changed.
  • Loading branch information
hehua2008 committed Apr 1, 2024
1 parent acced70 commit 21f6f0b
Showing 1 changed file with 3 additions and 3 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -235,15 +235,15 @@ public fun GlideSubcomposition(
}

val requestState: MutableState<RequestState> =
remember(model, requestManager, requestBuilderTransform) {
remember(requestBuilder) {
mutableStateOf(RequestState.Loading)
}
val painter: MutableState<Painter?> = remember(model, requestManager, requestBuilderTransform) {
val painter: MutableState<Painter?> = remember(requestBuilder) {
mutableStateOf(null)
}

val requestListener: StateTrackingListener =
remember(model, requestManager, requestBuilderTransform) {
remember(requestBuilder) {
StateTrackingListener(
requestState,
painter
Expand Down

0 comments on commit 21f6f0b

Please sign in to comment.