Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add indicators and test data #167

Merged
merged 13 commits into from Nov 9, 2020
Merged

Add indicators and test data #167

merged 13 commits into from Nov 9, 2020

Conversation

lit26
Copy link
Collaborator

@lit26 lit26 commented Jun 7, 2020

Adding Scheff Trend Cycle indicator
Manually copy data from tradeview charts. Testing data round to 2 decimal places

Adding Stoch RSI indicator, percentage volume oscillator, percentage price oscillator, ulcer index

@lit26 lit26 changed the title Add Schaff Trend Cycle indicator and testing data Add Schaff Trend Cycle indicator, Stoch RSI and STC testing data Jun 7, 2020
@lit26 lit26 changed the title Add Schaff Trend Cycle indicator, Stoch RSI and STC testing data Add indicators and test data Jun 7, 2020
@bukosabino bukosabino self-assigned this Jun 7, 2020
@bukosabino
Copy link
Owner

Congratulations on your work @lit26

Let me know when the pull request is ready for revision!

Best,
Dario

@lit26
Copy link
Collaborator Author

lit26 commented Jun 7, 2020

Sure, you can review the previous commit.

Best,
Tianning

@bukosabino
Copy link
Owner

Hey @lit26 ,

Sorry for the delay. I am reviewing the PR, and I have a question:

What is the origin of ta/tests/data/cs-stc.csv? We will need more rows in the file to test the results correctly.

Best,
Dario

@lit26
Copy link
Collaborator Author

lit26 commented Aug 1, 2020

I copy the data from tradeview.com.

@bukosabino bukosabino merged commit aabf780 into bukosabino:master Nov 9, 2020
@bukosabino
Copy link
Owner

bukosabino commented Nov 9, 2020

Hey @lit26 ,

Your work was included in the 0.6.0 version of the library.

Thank you so much for your collaboration!

Best,
Dario

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants