Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Keltner Channels improvements and volume indicators isolation #131

Merged
merged 5 commits into from Mar 21, 2020

Conversation

bukosabino
Copy link
Owner

@bukosabino bukosabino commented Mar 21, 2020

  • Keltner Channel:

    • Fixing bug on Keltner channel high band calculation. Based on: keltner_channel_hband incorrect output? #126
    • Included percentage band and width band indicators for Keltner Channel.
    • Included 2 ways to calculate the centerline of Keltner Channel: original version (SMA of typical price) vs modern version (EMA of close)
  • Volume indicators isolation: Isolate all the indicators using the volume input feature to get all together using add_volume_ta wrapper function. Based on: Volume indicators isolation #129

@bukosabino bukosabino merged commit 2039856 into master Mar 21, 2020
@bukosabino bukosabino changed the title Develop Keltner Channels improvements and volume indicators isolation Mar 21, 2020
@fettunch
Copy link

Hi @bukosabino ,

is it planned not to expose the ov parameters to the methods keltner_channel_xxxx? I see this param can only be set when instantiate KelnerChannel class and cannot be passed in when calling a single method.

Thanks in advance for your attention.

@bukosabino
Copy link
Owner Author

Great @fettunch ,

I will add this option asap.

Thanks for your advice!

@bukosabino
Copy link
Owner Author

Hi @fettunch ,

This fix is included in the last library version (0.5.17).

Update to use it:

pip install -U ta

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants