Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump coverage requirement to something >= 5.0 #1415

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

Cynical-Optimist
Copy link

See original merge request on GitLab
In GitLab by [Gitlab user @jjardon] on Apr 5, 2020, 11:14

From https://coverage.readthedocs.io/en/coverage-5.0.4/changes.html#changes:

  • Only 5.0a2 pass all python3.8 tests
  • Multiprocessing support in Python 3.8 was fixed in 5.0a6

Fixes #1173

Following
https://coverage.readthedocs.io/en/coverage-5.0.4/changes.html#changes:

- Only 5.0a2 pass all python3.8 tests
- Multiprocessing support in Python 3.8 was fixed in 5.0a6
@Cynical-Optimist
Copy link
Author

In GitLab by [Gitlab user @jjardon] on Apr 5, 2020, 11:19

changed the description

@Cynical-Optimist
Copy link
Author

In GitLab by [Gitlab user @jjardon] on Apr 5, 2020, 11:22

changed the description

@Cynical-Optimist
Copy link
Author

In GitLab by [Gitlab user @jjardon] on Apr 5, 2020, 11:23

changed the description

@Cynical-Optimist
Copy link
Author

In GitLab by [Gitlab user @jjardon] on Apr 5, 2020, 11:59

changed title from {-Update python dependencies-} to {+Bump coverage requirement to something >= 5.0+}

@Cynical-Optimist
Copy link
Author

In GitLab by [Gitlab user @jjardon] on Apr 5, 2020, 11:59

changed the description

@Cynical-Optimist
Copy link
Author

In GitLab by [Gitlab user @jjardon] on Apr 5, 2020, 12:00

added 1 commit

  • 469f7e7 - Bump coverage requirement to something >= 5.0

Compare with previous version

@Cynical-Optimist
Copy link
Author

In GitLab by [Gitlab user @jjardon] on Apr 5, 2020, 13:28

added 1 commit

  • c9709a00 - Enable python3.8 coverage

Compare with previous version

@Cynical-Optimist
Copy link
Author

In GitLab by [Gitlab user @jjardon] on Apr 5, 2020, 13:30

added 1 commit

  • 8b02e7b5 - Enable python3.8 coverage

Compare with previous version

@Cynical-Optimist
Copy link
Author

In GitLab by [Gitlab user @jjardon] on Apr 18, 2020, 18:17

added 53 commits

  • 8b02e7b5...f093e630 - 51 commits from branch master
  • 73e140d - Bump coverage requirement to something >= 5.0
  • cafdc63 - Enable python3.8 coverage

Compare with previous version

@Cynical-Optimist
Copy link
Author

In GitLab by [Gitlab user @cs-shadow] on Apr 21, 2020, 12:46

Commented on .gitlab-ci.yml line 97

the tests seem to be failing at the moment, but even if they pass, we shouldn't remove this entirely.

The first comment about multiple python version still applies, however the second one won't (once the CI failures are fixed). This should become:

    # This particular testsuite image has both Python 3.7 and Python 3.8 so we
    # need to explicitly force the 3.8 environment.
    # Once Python 3.8 is available in distros, we should switch to such an
    TOXENV: py38, py38-plugins

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants