Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature/524 download acceptance assets #550

Merged
merged 5 commits into from
Apr 8, 2020
Merged

Feature/524 download acceptance assets #550

merged 5 commits into from
Apr 8, 2020

Commits on Apr 7, 2020

  1. Download combo suite dependencies if not provided 

    - Input paths manager gathers inputs from enviroment and fills in
  missing inputs for the provided run combinations
- GitHub asset fetcher queries GitHub for release versions and assets
- Versions and assets are cached in PACK_HOME
- Re-arrange some setup code in acceptance_test.go to be more readable

Signed-off-by: Natalie Arellano <narellano@vmware.com>
    @natalieparellano
    natalieparellano committed Apr 7, 2020
    Configuration menu
    Copy the full SHA
    8c68492 View commit details
    Browse the repository at this point in the history

  2. Update per review comments. 

    Signed-off-by: Natalie Arellano <narellano@vmware.com>
    @natalieparellano
    natalieparellano committed Apr 7, 2020
    Configuration menu
    Copy the full SHA
    1f16a78 View commit details
    Browse the repository at this point in the history

  3. Remove newlines 

    They are unnecessary.

Signed-off-by: Natalie Arellano <narellano@vmware.com>
    @natalieparellano
    natalieparellano committed Apr 7, 2020
    Configuration menu
    Copy the full SHA
    f90679d View commit details
    Browse the repository at this point in the history

Commits on Apr 8, 2020

  1. Update lifecycle expression 

    We always want the Linux binaries, even on Windows.

Signed-off-by: Natalie Arellano <narellano@vmware.com>
    @natalieparellano
    natalieparellano committed Apr 8, 2020
    Configuration menu
    Copy the full SHA
    e029c63 View commit details
    Browse the repository at this point in the history

  2. Use new way of downloading assets in GitHub action workflow 

    Adds authentication to the GithubAssetFetcher to avoid rate limiting.

Signed-off-by: Natalie Arellano <narellano@vmware.com>
    @natalieparellano
    natalieparellano committed Apr 8, 2020
    Configuration menu
    Copy the full SHA
    2d1d5b5 View commit details
    Browse the repository at this point in the history