-
Notifications
You must be signed in to change notification settings - Fork 278
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Removing validation of deprecated io.buildpacks.stack.id #2119
base: main
Are you sure you want to change the base?
Conversation
Signed-off-by: Pavlo Glushko <pawel.glushko@gmail.com>
@natalieparellano I've changed validation to warning, and build process continues, but now there is error on next step. After change I tried to executed command mentioned in issue got nil pointer dereference
|
Signed-off-by: Pavlo Glushko <pawel.glushko@gmail.com>
@pglushko thanks for making the changes. I think we now need to update the acceptance test here: pack/acceptance/acceptance_test.go Line 1823 in 12b7d24
|
Summary
Replaces the error with a warning.
Output
Warning: No schema version declared in project.toml, defaulting to schema version 0.1
latest: Pulling from paketobuildpacks/builder-jammy-base
Digest: sha256:9bb4d01f8d42ccb9aa3b6b10a5876c8913e3ba9709882f18c9bd8c54f46d862b
Status: Image is up to date for paketobuildpacks/builder-jammy-base:latest
latest: Pulling from buildpacks/builder/php
Digest: sha256:91065e07a53b1c048fcaf8e49936a9d19c388b2dfdf2e7e589885aab2f5aae79
Status: Image is up to date for gcr.io/buildpacks/builder/php:latest
Warning: deprecated usage of stack
Before
Error message that interrupted build process
After
Warning message, build continues
Documentation
https://buildpacks.io/docs/for-app-developers/concepts/base-images/stack/
Related
#2104
Resolves #2104