feat(pack): add support for scaffolding new extensions #2041
Conversation
update support for newExtension
add support for extension new
add support for scaffolding new extensions
enable NewExtension method in MockPackClient
enable support for new extension
enable newextension
add test for newExtension
add new Extension in client
github-actions
bot
added
the
type/enhancement
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #2041 +/- ##
==========================================
- Coverage 79.63% 79.30% -0.32%
==========================================
Files 176 177 +1
Lines 13214 13367 +153
==========================================
+ Hits 10522 10600 +78
- Misses 2022 2093 +71
- Partials 670 674 +4
Flags with carried forward coverage won't be shown. Click here to find out more. |
sarthaksarthak9
changed the title
| } | ||
|
|
||
| func (e *ExtensionDescriptor) EnsureStackSupport(_ string, _ []string, _ bool) error { | ||
| return nil | ||
| } | ||
|
|
||
| func (e *ExtensionDescriptor) EnsureTargetSupport(_, _, _, _ string) error { | ||
| return nil | ||
| func (e *ExtensionDescriptor) EnsureTargetSupport(os, arch, distroName, distroVersion string) error { |
There was a problem hiding this comment.
@jjbustamante are you aware of any existing logic we can re-use to validate that extensions support targets?
There was a problem hiding this comment.
I think this code is similar to this one maybe we can try to refactor it and externalize it to be reuse in both places?
There was a problem hiding this comment.
@jjbustamante could you please give some clarification on the appropriate directory for storing the refactored files!! Any additional information about the specific files or workflow would be super helpful!!
There was a problem hiding this comment.
@jjbustamante @natalieparellano I think a direct refactoring using a common function might not be feasible due to the structural differences (ExtensionDescriptor and BuildpackDescriptor). While the two structs share similarities, they do have some distinct fields.
There was a problem hiding this comment.
@sarthaksarthak9 thank you for this, the PR is progressing nicely. I left a few comments :)
thank you for reviewing :) |
remove the stack flag and update the commands
remove the unnecessary indentation
update the unit test
Add support for scaffolding new extensions
Summary
Just like scaffold new buildpacks, we should be able to scaffold new extensions
Output
Before
After
Documentation
Related
Resolves #1636