Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Simplify Build Acceptance Tests #1498

Draft
wants to merge 18 commits into
base: main
Choose a base branch
from
Draft

Conversation

jromero
Copy link
Member

@jromero jromero commented Aug 11, 2022

Summary

The goal of this set of work is to minimize the level of effort for contributors when adding new build-related features to pack while maintaining the same level of quality via acceptance tests.

TODO

Output

Before

After

Documentation

  • Should this change be documented?
    • Yes, see #___
    • No

Related

Resolves #___

Signed-off-by: Javier Romero <root@jromero.codes>
Signed-off-by: Javier Romero <root@jromero.codes>
Signed-off-by: Javier Romero <root@jromero.codes>
@github-actions github-actions bot added this to the 0.28.0 milestone Aug 11, 2022
@github-actions github-actions bot added type/chore Issue that requests non-user facing changes. type/enhancement Issue that requests a new feature or improvement. labels Aug 11, 2022
Signed-off-by: Javier Romero <root@jromero.codes>
Signed-off-by: Javier Romero <root@jromero.codes>
Signed-off-by: Javier Romero <root@jromero.codes>
Signed-off-by: Javier Romero <root@jromero.codes>
Signed-off-by: Javier Romero <root@jromero.codes>
Signed-off-by: Javier Romero <root@jromero.codes>
Signed-off-by: Javier Romero <root@jromero.codes>
Signed-off-by: Javier Romero <root@jromero.codes>
Signed-off-by: Javier Romero <root@jromero.codes>
Signed-off-by: Javier Romero <root@jromero.codes>
Signed-off-by: Javier Romero <root@jromero.codes>
…e tests in sequence

Signed-off-by: Javier Romero <root@jromero.codes>
@codecov
Copy link

codecov bot commented Sep 15, 2022

Codecov Report

Merging #1498 (a520115) into main (100f656) will increase coverage by 0.14%.
The diff coverage is n/a.

❗ Current head a520115 differs from pull request most recent head 8330cb9. Consider uploading reports for the commit 8330cb9 to get more accurate results

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1498      +/-   ##
==========================================
+ Coverage   81.13%   81.26%   +0.14%     
==========================================
  Files         155      154       -1     
  Lines       10084    10021      -63     
==========================================
- Hits         8181     8143      -38     
+ Misses       1420     1397      -23     
+ Partials      483      481       -2     
Flag Coverage Δ
os_linux 80.02% <ø> (+0.10%) ⬆️
os_macos 77.48% <ø> (+0.11%) ⬆️
os_windows 80.36% <ø> (+0.10%) ⬆️
unit 81.26% <ø> (+0.14%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

@jromero jromero modified the milestones: 0.28.0, 0.29.0 Sep 16, 2022
@dfreilich dfreilich modified the milestones: 0.29.0, 0.30.0 Mar 26, 2023
@natalieparellano natalieparellano modified the milestones: 0.30.0, 0.31.0 May 19, 2023
@jjbustamante jjbustamante modified the milestones: 0.32.0, 0.33.0 Oct 17, 2023
@jjbustamante jjbustamante removed this from the 0.33.0 milestone Nov 22, 2023
@jjbustamante jjbustamante added this to the 0.35.0 milestone Mar 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type/chore Issue that requests non-user facing changes. type/enhancement Issue that requests a new feature or improvement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants