Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CI: Fix setup-go on windows-lcow runner #1493

Closed
wants to merge 2 commits into from
Closed

CI: Fix setup-go on windows-lcow runner #1493

wants to merge 2 commits into from

Conversation

jromero
Copy link
Member

@jromero jromero commented Jul 28, 2022

This PR temporarily addresses an issue in the setup-go action that prevents downloading new go versions on Windows.

These changes can be reverted after actions/setup-go#241 is resolved.

@jromero jromero requested a review from a team as a code owner July 28, 2022 20:13
@github-actions github-actions bot added this to the 0.28.0 milestone Jul 28, 2022
@github-actions github-actions bot added the type/chore Issue that requests non-user facing changes. label Jul 28, 2022
@jromero jromero force-pushed the ci/fix-lcow branch 3 times, most recently from 8fa9ade to 8020712 Compare July 29, 2022 00:20
Signed-off-by: Javier Romero <root@jromero.codes>
@jromero jromero changed the title WIP: use patched setup-go action CI: Fix setup-go on windows-lcow runner Jul 29, 2022
@codecov
Copy link

codecov bot commented Jul 29, 2022

Codecov Report

Merging #1493 (3c8a38e) into main (ab92e10) will increase coverage by 1.04%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1493      +/-   ##
==========================================
+ Coverage   80.35%   81.38%   +1.04%     
==========================================
  Files         152      152              
  Lines        9864     9864              
==========================================
+ Hits         7925     8027     +102     
+ Misses       1462     1360     -102     
  Partials      477      477              
Flag Coverage Δ
os_linux 80.14% <ø> (+0.04%) ⬆️
os_macos 77.54% <ø> (ø)
os_windows 81.26% <ø> (+1.04%) ⬆️
unit 81.38% <ø> (+1.04%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

@jromero
Copy link
Member Author

jromero commented Aug 2, 2022

Closing this PR since just by the simple fact of putting up this PR with the patched version downloaded the necessary go version on the current custom runner. It is now being pulled from cache on the main pipelines.

This PR provided a workaround that resolved the current issue. The hope is that actions/setup-go#250 will be merged and released by the time either a) we use a different version or b) we rebuild our custom runner.

@jromero jromero closed this Aug 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type/chore Issue that requests non-user facing changes.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant