Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove validation of deprecated io.buildpacks.stack.id #2104

Open
matthewrobertson opened this issue Mar 20, 2024 · 2 comments · May be fixed by #2119
Open

Remove validation of deprecated io.buildpacks.stack.id #2104

matthewrobertson opened this issue Mar 20, 2024 · 2 comments · May be fixed by #2119
Labels
good first issue A good first issue to get started with. status/ready Issue ready to be worked on. type/bug Issue that reports an unexpected behaviour.
Milestone
0.35.0

Comments

@matthewrobertson
Copy link

Summary

Pack still has logic that validates the builder and run image have a matching value set for the io.buildpacks.stack.id here. This label is deprecated as of platform v0.12 so we should probably weaken this validation.

Reproduction

Run a pack build using a packeto builder and google run image:

pack build stack-validation \
  --builder paketobuildpacks/builder-jammy-base
  --run-image gcr.io/buildpacks
Current behavior

Build fails with an error message about mistmatched stack IDs

run-image stack "google.22" does not match builder stackID...

Expected behavior

The builder and run image are both derived from Ubuntu Jammy so we should allow the build proceed

Environment

Linux

pack info

All versions of pack impacted

docker info

N/A
@matthewrobertson matthewrobertson added status/triage Issue or PR that requires contributor attention. type/bug Issue that reports an unexpected behaviour. labels Mar 20, 2024
@natalieparellano natalieparellano added this to the 0.34.0 milestone Mar 26, 2024
@natalieparellano
Copy link
Member

This might benefit from some synchronous discussion so I've added it as a "future topic" for one of our Working Groups

@natalieparellano natalieparellano added status/discussion-needed Issue or PR that requires in-depth discussion. and removed status/triage Issue or PR that requires contributor attention. labels Mar 26, 2024
@natalieparellano
Copy link
Member

Discussed in 3/28 Working Group: we think we can replace the error with a warning. The warning should probably note that stacks are deprecated so that folks who are not using stacks can simply ignore it.

@natalieparellano natalieparellano added status/ready Issue ready to be worked on. and removed status/discussion-needed Issue or PR that requires in-depth discussion. labels Mar 28, 2024
@jjbustamante jjbustamante added the good first issue A good first issue to get started with. label Apr 1, 2024
@jjbustamante jjbustamante modified the milestones: 0.34.0, 0.35.0 Apr 3, 2024
@pglushko pglushko linked a pull request Apr 7, 2024 that will close this issue
Draft
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue A good first issue to get started with. status/ready Issue ready to be worked on. type/bug Issue that reports an unexpected behaviour.
Projects
None yet
Milestone
0.35.0
Development

Successfully merging a pull request may close this issue.

Removing validation of deprecated io.buildpacks.stack.id pglushko/pack
3 participants
@matthewrobertson @jjbustamante @natalieparellano