Update keyring & go-keychain for macOS 11 fix #101
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Otherwise the build fails on macOS 11 Big Sur with: \# github.com/keybase/go-keychain cgo-gcc-prolog:203:11: warning: 'SecTrustedApplicationCreateFromPath' is deprecated: first deprecated in macOS 10.15 - No longer supported [-Wdeprecated-declarations] /Library/Developer/CommandLineTools/SDKs/MacOSX.sdk/System/Library/Frameworks/Security.framework/Headers/SecTrustedApplication.h:59:10: note: 'SecTrustedApplicationCreateFromPath' has been explicitly marked deprecated here See also: 99designs/keyring#56 (comment) 99designs/keyring#66 keybase/go-keychain#55 99designs/aws-vault#427
yob
reviewed
Dec 3, 2020
| @@ -37,3 +37,5 @@ require ( | |||
| google.golang.org/appengine v1.0.0 // indirect | |||
| gopkg.in/alecthomas/kingpin.v2 v2.2.6 | |||
| ) | |||
|
|
|||
| replace github.com/keybase/go-keychain => github.com/99designs/go-keychain v0.0.0-20191008050251-8e49817e8af4 | |||
There was a problem hiding this comment.
Could we also change all references from github.com/keybase/go-keychain to github.com/99designs/go-keychain, but this indicates we expect the replacement to be temporary?
There was a problem hiding this comment.
I think it's trickier than that because it's an indirect dependency, via 99designs/keyring; I think we'd have to vendor that and patch its imports too. I guess this is what replace was made for; I've never used it before, I just cargo-culted @mtibben's comment advice ;)
yob
approved these changes
Dec 3, 2020
JuanitoFatas
approved these changes
Dec 3, 2020
|
Oh you already fixed this! Haha |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Otherwise the build fails on macOS 11 Big Sur with:
Lots more background in: