Fix CI docs failures by reverting towncrier to 18.5.0 #4259
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
why didn't we see that before? |
|
Because it requires a newsfragment and I guess at the time of the upgrade there were no newsfragments present. For local test this suffices: |
|
thanks, this indeed fixes things |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The towncrier dependency dropped the python 2.7 support in 18.6.0 (see twisted/towncrier@d0068cc). This got noticed in twisted/towncrier#121 and fixed for a future version of towncrier which is not yet released. Until it's released and we can upgrade we should probably revert to an older version of towncrier.
This PR reverts to towncrier 18.5.0.
Contributor Checklist:
master/buildbot/newsfragmentdirectory (and read theREADME.txtin that directory)