Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix failing CI #143

Merged
merged 3 commits into from Jan 13, 2022
Merged

Fix failing CI #143

merged 3 commits into from Jan 13, 2022

Conversation

imjoehaines
Copy link
Member

@imjoehaines imjoehaines commented Jan 13, 2022

Goal

CI has been failing recently because the Maze Runner fixtures no longer build successfully:

Unable to find a compatible set of packages based on your non-dev requirements alone.
Your requirements can be resolved successfully when require-dev packages are present.
You may need to move packages from require-dev or some of their dependencies to require.

Problem 1
- Root composer.json requires bugsnag/bugsnag-symfony dev-master as 99.99.99, found bugsnag/bugsnag-symfony[dev-main] but it does not match the constraint. Perhaps dev-master was renamed to dev-main?

This error seems to be caused by Composer no longer accepting dev-master in a package installed from a directory, which is how we install bugsnag-symfony in the test fixtures

This seems to be caused by composer/composer#10372, though that PR adds an alias for dev-master so I'm not 100% sure I haven't been able to reproduce this outside of this repo, so I'm assuming it's something weird we're doing

Finally, there was an unrelated error caused by cucumber/gherkin failing to parse something from its own test suite:

features/fixtures/symfony-4/bugsnag-symfony/vendor/bundle/ruby/3.0.0/gems/gherkin-5.1.0/spec/gherkin/stream/test_fr.feature: Parser errors:
15
expected: #EOF, #Language, #TagLine, #FeatureLine, #Comment, #Empty, got 'Fonctionnalité: Bonjour'
16
expected: #EOF, #Language, #TagLine, #FeatureLine, #Comment, #Empty, got 'Scénario: Monde'
17
expected: #EOF, #Language, #TagLine, #FeatureLine, #Comment, #Empty, got 'Soit une étape' (Cucumber::Core::Gherkin::ParseError)
18
https://github.com/bugsnag/bugsnag-symfony/runs/4804287510?check_suite_focus=true#step:5:14

I'm not sure this started happening when we have a lock file for Maze Runner & its dependencies, but I've also fixed this

Composer 2.2 seems to have broken 'dev-master' for path repositories

Using 'dev-main' works with no other changes
2.2 is an LTS release, so should hopefully be stable in future and
less likely to break unexpectedly than the latest version
@imjoehaines imjoehaines requested a review from a team January 13, 2022 14:21
Copy link

@twometresteve twometresteve left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM pending successful CI.

@imjoehaines imjoehaines merged commit d094e0e into master Jan 13, 2022
@imjoehaines imjoehaines deleted the fix-ci branch January 13, 2022 14:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants