Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Workaround Bundler's friendly errors swallowing error reports #634

Merged
merged 5 commits into from Sep 8, 2020
Merged

Workaround Bundler's friendly errors swallowing error reports #634

merged 5 commits into from Sep 8, 2020

Commits on Sep 8, 2020

  1. Workaround Bundler friendly errors not reporting 

    We avoid reporting SystemExit exceptions as they aren't (usually)
errors. However, Bundler's friendly errors will wrap an exception
in a SystemExit — in this case we need to unwrap to the original
exception
    @imjoehaines
    imjoehaines committed Sep 8, 2020
    Configuration menu
    Copy the full SHA
    5939984 View commit details
    Browse the repository at this point in the history

  2. Make unhandled fixtures executable

    @imjoehaines
    imjoehaines committed Sep 8, 2020
    Configuration menu
    Copy the full SHA
    66d5d66 View commit details
    Browse the repository at this point in the history

  3. Run tests with bundle exec & bundle exec ruby

    @imjoehaines
    imjoehaines committed Sep 8, 2020
    Configuration menu
    Copy the full SHA
    1feeccc View commit details
    Browse the repository at this point in the history

  4. Add test with exit after an exception 

    This proves that we don't unwrap exceptions too much when unwrapping
Bundler's friendly errors. In this case, the backtrace will look
something like this:

1. Bundler friendly errors
2. Our exit
3. The exception we raised

We want to drop 1. because it may be hiding a real exception, however
we don't want to drop 2. because it's a deliberate exit

This test proves that we don't go too far and end up with an exception
that we would notify about
    @imjoehaines
    imjoehaines committed Sep 8, 2020
    Configuration menu
    Copy the full SHA
    de64cba View commit details
    Browse the repository at this point in the history

  5. Add changelog entry

    @imjoehaines
    imjoehaines committed Sep 8, 2020
    Configuration menu
    Copy the full SHA
    d428bf6 View commit details
    Browse the repository at this point in the history