Skip to content

Ensure that exception message is never null #256

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Feb 28, 2018
Merged

Ensure that exception message is never null #256

merged 1 commit into from
Feb 28, 2018
+13 −2

Conversation

fractalwrench
Copy link
Contributor

@fractalwrench fractalwrench commented Feb 28, 2018 •
edited
Loading

The exception message is added to the breadcrumb metadata, which can cause a crash in the NDK when accessing the value via the JNI.

@coveralls
Copy link

coveralls commented Feb 28, 2018 •
edited
Loading

Pull Request Test Coverage Report for Build 1154

  • 2 of 2 (100.0%) changed or added relevant lines in 1 file are covered.
  • 5 unchanged lines in 2 files lost coverage.
  • Overall coverage increased (+0.2%) to 70.947%
Files with Coverage Reduction New Missed Lines %
sdk/src/main/java/com/bugsnag/android/DeviceData.java 2 76.69%
sdk/src/main/java/com/bugsnag/android/Client.java 3 52.58%
Totals Coverage Status
Change from base Build 1142: 0.2%
Covered Lines: 1768
Relevant Lines: 2492
💛 - Coveralls

@fractalwrench fractalwrench requested a review from Pezzah February 28, 2018 11:01
@fractalwrench fractalwrench merged commit dfc4c12 into master Feb 28, 2018
@fractalwrench fractalwrench deleted the localised-message-ndk-fix branch February 28, 2018 12:59
rich-bugsnag pushed a commit that referenced this pull request Sep 3, 2021
@fractalwrench
Merge pull request #256 from bugsnag/PLAT-6371/e2e-smoke-scenarios

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
GPG key ID: 4AEE18F83AFDEB23
Expired
Verified
Learn about vigilant mode
e9fe85b 
Add E2E smoke tests for Android
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Pezzah Pezzah

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@fractalwrench @coveralls @Pezzah