Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

StandardConstraintResolver interface needs to return errors #58

Open
rodaine opened this issue Oct 2, 2023 · 0 comments
Open

StandardConstraintResolver interface needs to return errors #58

rodaine opened this issue Oct 2, 2023 · 0 comments
Labels
Feature New feature or request

Comments

@rodaine
Copy link
Member

rodaine commented Oct 2, 2023

The current StandardConstraintResolver interface does not support returning errors, preferring the implementation to fail silently if it cannot resolve the constraints. But in practice, resolving the extension is fallible (very apparent in #57). This will be a breaking change to the interface and a behavioral change to the library (instead of failing silently and not producing a compilation error, the validator would return a compilation error caused by the resolver's error).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feature New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant