Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecated usage of github.com/golang/protobuf/ptypes #456

Closed
codefromthecrypt opened this issue Mar 31, 2021 · 1 comment · Fixed by #459
Closed

Deprecated usage of github.com/golang/protobuf/ptypes #456

codefromthecrypt opened this issue Mar 31, 2021 · 1 comment · Fixed by #459

Comments

@codefromthecrypt
Copy link

The most recent release of golang/protobuf formally deprecated github.com/golang/protobuf/ptypes

golang/protobuf#1306

// Deprecated: Use the "google.golang.org/protobuf" module instead.
module github.com/golang/protobuf

I noticed the code generator still uses the old namespace. Can there be a flag or other approach to use a non-deprecated one?

@akonradi
Copy link
Contributor

akonradi commented Mar 31, 2021

Is this as simple as replacing one with the other in PGV? If so, feel free to send a PR! Unless there's a compelling reason, we should just migrate instead of trying to maintain compatibility with both.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants