-
Notifications
You must be signed in to change notification settings - Fork 243
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Change buf beta registry label archive/unarchive
to buf beta registry archive/unarchive
#2980
Conversation
…try archive/unarchive`
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
My comments are mostly about the command's docs; otherwise looks good.
I wonder if we should consider target modules in the workspace as well. The |
I tried to bring this up yesterday, but I think it got a little lost. Right now the behaviour would be that this would error, since it's a single RPC call (per registry, but everything should be from the same registry), and I think this is a pretty reasonable behaviour. We are disallowing this for |
I think matching the API behavior here is fine since the alternative is just to target the specific modules that have the label you want to archive. |
This PR changes
buf beta registry label archive/unarchive
tobuf beta registry archive/unarchive
, which is able to take aworkspace input and archive/unarchive all labels for modules
in the workspace.
This UX change is needed to support uses-cases such as
GitHub Actions.