Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change buf beta registry label archive/unarchive to buf beta registry archive/unarchive #2980

Merged
merged 4 commits into from
May 15, 2024

Conversation

doriable
Copy link
Member

This PR changes buf beta registry label archive/unarchive to
buf beta registry archive/unarchive, which is able to take a
workspace input and archive/unarchive all labels for modules
in the workspace.
This UX change is needed to support uses-cases such as
GitHub Actions.

Copy link
Contributor

@saquibmian saquibmian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My comments are mostly about the command's docs; otherwise looks good.

CHANGELOG.md Outdated Show resolved Hide resolved
@saquibmian
Copy link
Contributor

I wonder if we should consider target modules in the workspace as well. The Archive/Unarchive RPCs currently does not allow archiving/unarchiving labels that don't exist. Does that pose a problem where the user would like to archive a label that only exists for some modules in the workspace but not for others?

@doriable
Copy link
Member Author

Does that pose a problem where the user would like to archive a label that only exists for some modules in the workspace but not for others?

I tried to bring this up yesterday, but I think it got a little lost. Right now the behaviour would be that this would error, since it's a single RPC call (per registry, but everything should be from the same registry), and I think this is a pretty reasonable behaviour. We are disallowing this for v1 workspaces, and so users with v1 workspaces would still need to continue with the workflows they already have to manage each individual module. This will start coming up for v2 workspaces, but I am okay with launching with the behaviour of error-ing and then going from there. But open to other's thoughts on this.

@nicksnyder
Copy link
Member

I think matching the API behavior here is fine since the alternative is just to target the specific modules that have the label you want to archive.

@bufdev bufdev merged commit bcf427c into dev May 15, 2024
9 checks passed
@bufdev bufdev deleted the BSR-3748-BSR-3749-changes-to-archive-unarchive branch May 15, 2024 20:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants