Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

1.29.0-1 causing issue during setup #188

Closed
vieux opened this issue Feb 21, 2024 · 9 comments · Fixed by #189
Closed

1.29.0-1 causing issue during setup #188

vieux opened this issue Feb 21, 2024 · 9 comments · Fixed by #189
Assignees

Comments

@vieux
Copy link

vieux commented Feb 21, 2024

From my github action:

Run bufbuild/buf-setup-action@v1
  with:
    buf_user: ***
    buf_api_token: ***
    github_token: ***
    version: 1.29.0-1
    buf_domain: buf.build
  env:
    GOPRIVATE: buf.build/gen/go
Setting up buf version "1.29.0-1"
Resolving the download URL for the current platform...
Error: Not Found - https://docs.github.com/rest/releases/releases#get-a-release-by-tag-name

@emcfarlane

@sicoyle
Copy link

sicoyle commented Feb 21, 2024

I can confirm this is indeed an issue rn so thanks for looking into this! 😅

emcfarlane added a commit that referenced this issue Feb 21, 2024
Release 1.29.0-1 used the wrong version for the CLI. Fixes the action.

Fixes #188
@emcfarlane
Copy link
Contributor

Sorry for the issue! Lastest should be at 1.29.0 and we will add better testing for future release. Thanks for reporting. Please let me know if you have any issues.

@passichenko
Copy link

I'm still seeing this error. Our setup is:

      - uses: bufbuild/buf-setup-action@v1
        with:
          buf_user: ${{ secrets.BUF_USER }}
          buf_api_token: ${{ secrets.BUF_API_TOKEN }}
          github_token: ${{ secrets.CI_PERSONAL_ACCESS_TOKEN }}

I'm not very familiar with github action versioning, but don't you need to cut a release? Or should we use some other tag?

@passichenko
Copy link

changing it to bufbuild/buf-setup-action@v1.29.0-1 worked

@emcfarlane
Copy link
Contributor

I believe the wrong version is being cached but should hopefully be fixed. I'll re-open until we can confirm.

@emcfarlane emcfarlane reopened this Feb 21, 2024
@passichenko
Copy link

maybe it's because this run failed and it didn't push to v1 branch?
https://github.com/bufbuild/buf-setup-action/actions/runs/7995772216

@emcfarlane
Copy link
Contributor

Thank you @passichenko ! That is exactly it, pushed up and checked, v1 resolves.

@Radisovik
Copy link

So going to v1.29.0-1 should make things happy? maybe my enterprise github is caching something...

Error: System.ArgumentOutOfRangeException: Specified argument was out of the range of valid values. (Parameter ''using: node20' is not supported, use 'docker', 'node12' or 'node16' instead.')
at GitHub.Runner.Worker.ActionManifestManager.ConvertRuns(IExecutionContext executionContext, TemplateContext templateContext, TemplateToken inputsToken, String fileRelativePath, MappingToken outputs)
at GitHub.Runner.Worker.ActionManifestManager.Load(IExecutionContext executionContext, String manifestFile)
Error: Fail to load bufbuild/buf-setup-action/v1.29.0-1/action.yml

@emcfarlane
Copy link
Contributor

@Radisovik thanks for reporting. This looks like a different issue related to the recent node version change. Could you use 1.29.0 for now to ensure you use the node16 runtime and raise an issue with more details?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants