Update the version of Node the action runs on from Node 16 to Node 20 #183
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
|
@doriable / @rubensf / @smallsamantha , may we get someone to take a look and review? |
emcfarlane
previously approved these changes
Feb 16, 2024
emcfarlane
reviewed
Feb 16, 2024
…-action into eo/update-action-node
Thanks! Fixed. |
emcfarlane
added a commit
that referenced
this pull request
Feb 20, 2024
Upgrade dependencies to latest and node runtime to v20. Following dependencies were upgraded with major version changes: - typescript and eslint: not an issue because the build and lint steps still pass - prettier: new formatting does not affect code - @actions/github: the only breaking change appears to be dropped support for Node 16 All code changes are related to formatting and LICENSE years. Fixes: - #183 - #173 - #172 - #159 - #149 - #144 - #141 - #140 - #137
|
Hey @orendain, we've pulled in and fixed as part of #185 which includes library version updates as well as the node runtime bump to v20. A new release of the actions package will be created when the buf cli is released. For now you can reference the commit hash to pull in the node changes. Thanks again for putting up the issue and the PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #182.
Modifies the action to run on Node 20 instead on Node 16.