Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove github ref type checking on push #27

Merged
merged 2 commits into from Dec 15, 2022
Merged

remove github ref type checking on push #27

merged 2 commits into from Dec 15, 2022

Conversation

cyinma
Copy link
Member

@cyinma cyinma commented Dec 15, 2022

fixes #26

This remove the checking of GITHUB_REF_TYPE environment variable equals to branch in the action, which was added to support draft. Also updated the readme example which is more aligned with the flow we suggest.

My original thought for this fix was to put the checking inside the block of if [ "${DRAFT}" == "true" ]; then so that its only check when it is expected to be a draft, but after thinking about this more it doesn't seems to be a necessary check for draft neither (or at least not something we should block for the user), as user might also want to only push as draft when pushing a git tag, so decided to just remove the GITHUB_REF_TYPE checking.

tested with an action condition of

on:
  push:
    tags:
      - push-to-bsr

and its working as expected (push to bsr main when adding a tag push-to-bsr)

@cyinma cyinma merged commit 1c45f6a into main Dec 15, 2022
@cyinma cyinma deleted the cyinma/fix-ref-tag branch December 15, 2022 17:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Breaking change introduced in v1.1.0
2 participants