remove github ref type checking on push #27
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #26
This remove the checking of
GITHUB_REF_TYPE
environment variable equals tobranch
in the action, which was added to support draft. Also updated the readme example which is more aligned with the flow we suggest.My original thought for this fix was to put the checking inside the block of
if [ "${DRAFT}" == "true" ]; then
so that its only check when it is expected to be a draft, but after thinking about this more it doesn't seems to be a necessary check for draft neither (or at least not something we should block for the user), as user might also want to only push as draft when pushing a git tag, so decided to just remove theGITHUB_REF_TYPE
checking.tested with an action condition of
and its working as expected (push to bsr
main
when adding a tagpush-to-bsr
)