New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Chore: Push burger slot to the same position as default burger #4037
base: dev
Are you sure you want to change the base?
Chore: Push burger slot to the same position as default burger #4037
Conversation
✅ Deploy Preview for buefy-org ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
@franciscoh017 Thanks for your PR! I will review and test your change. |
@franciscoh017 I have tested with the following simple component: <template>
<b-navbar>
<template #brand>
<b-navbar-item>
<img
src="https://raw.githubusercontent.com/buefy/buefy/dev/static/img/buefy-logo.png"
alt="Lightweight UI components for Vue.js based on Bulma"
>
</b-navbar-item>
</template>
<template #burger>
<p>🍔</p>
</template>
</b-navbar>
</template> I think it has a problem if the screen is wider than |
@kikuomax is it present on |
@franciscoh017 |
@franciscoh017 @wesdevpro
The following code should be equivalent to your PR: <template #burger>
<a href="#" class="ml-auto" role="button" aria-label="menu">🍔</a>
</template> |
Makes a lot of sense now that you mention it! |
Fixes #3906.
Proposed Changes
ml-auto
Example
Before
After