Skip to content

Commit

Permalink
Fix publish GitHub Actions workflow (#3956)
Browse files Browse the repository at this point in the history
* fix: dist was not built before publish to npm

- Fixes the issue that the `dist` folder was not built before publishing
  to npm. `package.json` used to include `prepare` script that runs
  `build:lib` script and `npm ci` built the `dist` folder. I removed
  `prepare` script in the commit ccbdc8e
  because `npm install` took very long. So we have to run `build:lib`
  before `publish` now.

* chore(gha): update npm_deploy dependencies

- Updates dependencies of `npm_deploy` GitHub Actions workflow:
    - Bump Node to v18.x
    - Bump actions/checkout to v4
    - Bump actions/setup-node to v4
  • Loading branch information
kikuomax committed Jan 3, 2024
1 parent 9ce3bf2 commit 83d8f05
Showing 1 changed file with 5 additions and 4 deletions.
9 changes: 5 additions & 4 deletions .github/workflows/npm_deploy.yml
Expand Up @@ -10,14 +10,15 @@ jobs:
contents: read
packages: write
steps:
- uses: actions/checkout@v3
- uses: actions/checkout@v4
# Setup .npmrc file to publish to GitHub Packages
- uses: actions/setup-node@v3
- uses: actions/setup-node@v4
with:
node-version: '16.x'
node-version: '18.x'
registry-url: 'https://registry.npmjs.org/'
scope: 'buefy'
- run: npm ci
- run: npm run build:lib
- run: npm publish --access public
env:
NODE_AUTH_TOKEN: ${{ secrets.NPM_TOKEN }}
NODE_AUTH_TOKEN: ${{ secrets.NPM_TOKEN }}

0 comments on commit 83d8f05

Please sign in to comment.