Support LDAP authentication with unauthorized reads #740
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JonasScharpf
force-pushed
the
feature/support-ldap
branch
from
faecd41
to
2452267
Compare
mostynb
reviewed
Apr 7, 2024
There was a problem hiding this comment.
Not bad, for first-time go code :) I will look some more tomorrow.
I wonder if there's a small ldap server we could spin up during an end-to-end test? https://github.com/bradleypeabody/godap might work.
* use LDAP fake server package * expose config from YAML function * update go repository and deps list
JonasScharpf
force-pushed
the
feature/support-ldap
branch
from
4ef6685
to
e2a1d74
Compare
JonasScharpf
commented
Apr 18, 2024
Sorry it took me longer than expected to get back to this. I should have some time to read through this while I'm travelling later this week. |
|
Hey @mostynb how are you doing? Might it be possible to find some time for this PR during your next trip? 😉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is based on #101 and resolves #100
It provides unauthorized reads when using LDAP, config via command line args and minimal config file testing for the new LDAP section
This is my first GO thing ever, so it might not be perfect