Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removed #6377 from release notes #2

Merged

Conversation

radarhere
Copy link

Suggestion for python-pillow#6377

Not every change to Pillow makes it into the release notes. Most just live in the changelog and in the GitHub release description.

Feel free to push back on this if you want, but I'm not convinced your change needs to be in the release notes?

@btrekkie
Copy link
Owner

Thanks, I didn't realize there were both release notes and a changelog. Shouldn't we also update CHANGES.rst? Should I do that or do you want to as part of this PR?

@btrekkie
Copy link
Owner

Also, shouldn't this commit be marked with "[ci skip]"?

@radarhere
Copy link
Author

The tradition is for CHANGES to be updated by a maintainer after a PR is merged.

I use '[ci skip]' sparingly, because the Ubuntu 3.10 CI job checks the docs, so even when just making documentation changes, I feel it's good to check that there isn't a syntax error in the documentation.

@btrekkie btrekkie merged commit f100726 into btrekkie:fix-round-to-palette Jun 20, 2022
@radarhere radarhere deleted the fix-round-to-palette branch June 20, 2022 00:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants