WIP: testing docker linter #911
Conversation
| && cd /tmp/tools \ | ||
| && go install -trimpath github.com/golangci/golangci-lint/cmd/golangci-lint@v1.46.0 \ | ||
| && chmod -R 777 /tmp/build/ \ | ||
| && git config --global --add safe.directory /build |
There was a problem hiding this comment.
We added this line when we didn't know what the actual issue was and it's more of an ugly hack. The "better" solution would be this environment variable: https://github.com/lightninglabs/pool/blob/master/tools/Dockerfile#L6
So just ENV GOFLAGS="-buildvcs=false".
We should probably update this in other projects too to make things more consistent (and to avoid us copying the "hacky" version to new projects).
|
|
||
| GOPATH := $(shell go env GOPATH) |
There was a problem hiding this comment.
nit: LINT_COMMIT below is now unused.
It would also be nice if we could remove the GOACC_COMMIT and GOIMPORTS_COMMIT values as well by creating a go.mod file in the tools directory that pins these versions, then just install them from the tools directory as we do here: https://github.com/lightninglabs/taproot-assets/blob/main/Makefile#L79
| && mkdir -p /tmp/build/.cache \ | ||
| && mkdir -p /tmp/build/.modcache \ | ||
| && cd /tmp/tools \ | ||
| && go install -trimpath github.com/golangci/golangci-lint/cmd/golangci-lint@v1.46.0 \ |
There was a problem hiding this comment.
Same comment here, re pinning the version in a go.mod file instead.
| @@ -42,6 +42,10 @@ func (m *mockChainClient) GetBlockHeader(*chainhash.Hash) (*wire.BlockHeader, | |||
| return nil, nil | |||
| } | |||
|
|
|||
| func (m *mockChainClient) GetBlockHeight(*chainhash.Hash) (int32, error) { | |||
There was a problem hiding this comment.
The same method needs to be added to the RPCClient.
I couldn't reproduce the CI lint results (no lint errors) locally.