Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

btcutil: update module to v2 #197

Closed
wants to merge 2 commits into from
Closed

btcutil: update module to v2 #197

wants to merge 2 commits into from

Conversation

Roasbeef
Copy link
Member

@Roasbeef Roasbeef commented May 20, 2021

In this commit, we update the top-level go module as well as all the
relevant imports to point to the new v2 version of the module. This
change is long overdue after a breaking change was made to the
hdkeychain package to fix a BIP 32
implementation divergence. A follow up PR will also update the psbt
module as well as significant changes have been made to the API and
logic since it was first added.

Fixes #193

In this commit, we update the top-level go module as well as all the
relevant imports to point to the new v2 version of the module. This
change is long overdue after a breaking change was made to the
[`hdkeychain` package](github.com/btcsuite/btcutil) to fix a BIP 32
implementation divergence. A follow up PR will also update the `psbt`
module as well as significant changes have been made to the API and
logic since it was first added.
@Roasbeef
Copy link
Member Author

Running into a bit of a chicken and the egg here:

--- FAIL: TestUseBlockHash (0.00s)
    builder_test.go:89: Address script build failed: unable to generate payment script for unsupported address type *btcutil.AddressScriptHash

txscript is still using the v1 version of the module, and PayToAddrScript does a type assertion to know which script to generate.

Ofc, we can't update txscript yet as the module doesn't really exist (v2, this PR switches things over but doesn't include the tag)....

Short term workaround would be to skip the test for now, then work on switching everything over on the btcd end, then make a final update here (which includes making everything a sub-module?).

@Roasbeef
Copy link
Member Author

Replaced by btcsuite/btcd#1785

@Roasbeef Roasbeef closed this Jan 11, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Requesting New Release (v1.0.2 seems outdated)
1 participant