blockchain: Test & Check Memory Usage #2167
Conversation
| resultShoulBeTrue := result == expectedSize | ||
|
|
||
| // Compare the expected result with the actual result | ||
| if resultShoulBeTrue { |
There was a problem hiding this comment.
It appears that there is a logical error in the condition if resultShoulBeTrue. This condition implies that the test should fail when the memory usage matches the expected size, which is the opposite of the intended behavior.
I recommend changing the condition to if !resultShoulBeTrue or if result != expectedSize, indicating that the test should fail when the memory usage does not match the expected size
There was a problem hiding this comment.
Additionally, it's important to note that totalMemoryUsage and maxTotalMemoryUsage represent different concepts. maxTotalMemoryUsage is the maximum memory usage allowed for the cache in normal circumstances, while totalMemoryUsage is the map size + the size that the utxo entries are taking up.
There was a problem hiding this comment.
Overall, thank you for your contribution to the project and for your efforts in writing tests.
Pull Request Test Coverage Report for Build 8680316882Warning: This coverage report may be inaccurate.This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.
Details
💛 - Coveralls |
Use the newUtxoCache function to create a 1MB simulated newUtxoCache instance.
Call the totalMemoryUsage method to compare the returned result to the expected size of 1 MB.
If the result is different from the expected size, the test fails and outputs an error message.
This test code is responsible for ensuring that the memory usage of newUtxoCache matches the expected value.