Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Browser Support (Neutrino) #2124

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Add Browser Support (Neutrino) #2124

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
a096a22
feat(`btcutil`): use an empty data directory on `js`
linden Feb 18, 2024
36e494c
feat(`addrmgr`): use `localStorage` instead of file-system on `js`
linden Feb 18, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
5 changes: 5 additions & 0 deletions btcutil/appdata.go
View file
Open in desktop
Expand Up @@ -23,6 +23,11 @@ func appDataDir(goos, appName string, roaming bool) string {
return "."
}

// Fallback to an empty string on js since we do not have a file system.
if goos == "js" {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does this case need to be handled elsewhere in practice?

return ""
}

// The caller really shouldn't prepend the appName with a period, but
// if they do, handle it gracefully by trimming it.
appName = strings.TrimPrefix(appName, ".")
Expand Down