[NO MERGE] tapscript: enable OP_CAT #2095
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
0xBEEFCAF3
reviewed
Jan 7, 2024
txscript/engine.go
Outdated
Comment on lines
338
to
339
| case OP_CAT: | ||
| return true |
There was a problem hiding this comment.
Just curious. Does removing this case still throw some error when CAT (0x7e) is being used in a segwitv0 or legacy context?
There was a problem hiding this comment.
Yes, if opcode is being executed without a taproot context, it will fall back to old behavior: 9541657#diff-27954f8a5853761d7c36b3084d7eb53d7c9a6788eac76b4b20dc573f723a8296R1954
halseth
commented
Jan 8, 2024
halseth
commented
Jan 24, 2024
| @@ -335,8 +335,6 @@ func (vm *Engine) isBranchExecuting() bool { | |||
| // conditional). | |||
| func isOpcodeDisabled(opcode byte) bool { | |||
| switch opcode { | |||
| case OP_CAT: | |||
There was a problem hiding this comment.
Similar to the discussion in Inquistion, this check must still be triggered for legacy script, since the opcode won't be executed if inside a conditional.
Pull Request Test Coverage Report for Build 8535288446Details
💛 - Coveralls |
|
Updated in line with reference implementation. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[SHOULD NOT BE MERGED]
Enabling OP_CAT as specified in BIP-CAT
Note this does currently lack any form of activation or flags for disabling it, hence many existing tests will fail.
Should not be merged before BIP is accepted and activation is decided on.