Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: set strconv.ParseFloat bitsize to 64 #2062

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

lilasxie
Copy link

strconv.ParseFloat will always treat bizSize parameter as 64 if we don't set it to 32, it's odd to set it to 0, although this won't affect the result

@coveralls
Copy link

Pull Request Test Coverage Report for Build 6898626179

Warning: This coverage report may be inaccurate.

We've detected an issue with your CI configuration that might affect the accuracy of this pull request's coverage report.
To ensure accuracy in future PRs, please see these guidelines.
A quick fix for this PR: rebase it; your next report should be accurate.

  • 1 of 1 (100.0%) changed or added relevant line in 1 file are covered.
  • 85 unchanged lines in 1 file lost coverage.
  • Overall coverage decreased (-0.2%) to 56.07%

Files with Coverage Reduction New Missed Lines %
rpcclient/infrastructure.go 85 39.08%
Totals Coverage Status
Change from base Build 6871622756: -0.2%
Covered Lines: 27953
Relevant Lines: 49854

💛 - Coveralls

Copy link
Collaborator

@halseth halseth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants