Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

btcjson,rpcclient: add converttopsbt to rpcclient #2044

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

btcjson,rpcclient: add converttopsbt to rpcclient #2044

wants to merge 1 commit into from

Conversation

wydengyre
Copy link
Contributor

No description provided.

@coveralls
Copy link

coveralls commented Oct 15, 2023 •
edited

Pull Request Test Coverage Report for Build 6523960217

  • 1 of 33 (3.03%) changed or added relevant lines in 2 files are covered.
  • 5 unchanged lines in 2 files lost coverage.
  • Overall coverage decreased (-0.04%) to 55.221%
Changes Missing Coverage Covered Lines Changed/Added Lines %
btcjson/chainsvrcmds.go 1 8 12.5%
rpcclient/rawtransactions.go 0 25 0.0%
Files with Coverage Reduction New Missed Lines %
btcutil/gcs/gcs.go 1 81.25%
peer/peer.go 4 73.2%
Totals Coverage Status
Change from base Build 6087638620: -0.04%
Covered Lines: 26913
Relevant Lines: 48737
💛 - Coveralls

@kcalvinalvin
Copy link
Collaborator

Is this so that the btcjson package can be used with bitcoin core?

@wydengyre
Copy link
Contributor Author

Is this so that the btcjson package can be used with bitcoin core?

Yes. If that's no longer a desired goal (my impression was that it was), I can just close this PR.

@Roasbeef
Copy link
Member

Yes. If that's no longer a desired goal (my impression was that it was), I can just close this PR.

See #1934 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@wydengyre @coveralls @kcalvinalvin @Roasbeef