Add miniscript implementation #1987
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pull Request Test Coverage Report for Build 5099410036Warning: This coverage report may be inaccurate.We've detected an issue with your CI configuration that might affect the accuracy of this pull request's coverage report.
💛 - Coveralls |
Currently, only the P2WSH context is supported. Miniscript for Taproot was not yet well specified at the time of writing. Currently, there is an open PR for Bitcoin Core at bitcoin/bitcoin#27255 which, when merged, can be taken as a reference. This implementation contains: - miniscript parser - type checker - malleability check - script length limit check (P2WSH standardness rule) - op count check (P2WSH consensus rule) - duplicate pubkey check - script generation - witness generation (satisfactions) - unit tests that create receive addresses based on some miniscripts and spend from them again (see `TestRedeem()`). Unit tests exist to check that this implementation's type checking passes some of the unit tests of rust-miniscript. See [./testdata](./testdata). Missing/todo: - timelock mixing check - stack size check (P2WSH standardness rule) - witness generation for thresh/multi currently has a naive implementation that is very inefficient (exponential runtime). This should be replaced with a fast algorithm. - maybe more Co-authored-by: Oliver Gugger <gugger@gmail.com>
This commit adds test vectors taken from https://github.com/rust-bitcoin/rust-miniscript/blob/a0648b3a4d63abbe53f621308614f97f04a04096/src/miniscript/ms_tests.rs to the miniscript implementation. Co-authored-by: Oliver Gugger <gugger@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds the Golang miniscript implementation authored by @benma in https://github.com/benma/miniscript-go to
txscript/miniscript(as requested by the author, see #1986).TODOs: