Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

rpcclient: fix crash in http retry handler #1856

Merged
merged 4 commits into from May 17, 2022
Merged

rpcclient: fix crash in http retry handler #1856

merged 4 commits into from May 17, 2022
+50 −16

Commits on May 13, 2022

  1. rpcclient: fix formatting

    @bhandras
    bhandras committed May 13, 2022
    Copy the full SHA
    ebed192 View commit details
    Browse the repository at this point in the history

  2. rpclient: fix masked error causing crash after max retries 

    This commit fixes the error that is masked inside the for loop's scope.
Previously after max retries the error didn't leave the for scope and
therefore httpResponse remained nil which in turn resulted in a crash.
    @bhandras
    bhandras committed May 13, 2022
    Copy the full SHA
    9665112 View commit details
    Browse the repository at this point in the history

  3. rpcclient: fix backoff logic 

    This commit removes Sleep() from the rety handler so that the shutdown
request is always respected. Furthermore the maximum retry count is corrected.
    @bhandras
    bhandras committed May 13, 2022
    Copy the full SHA
    9babf1f View commit details
    Browse the repository at this point in the history

  4. rpcclient: save the last error when retrying

    @bhandras
    bhandras committed May 13, 2022
    Copy the full SHA
    97313ac View commit details
    Browse the repository at this point in the history