Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

connmgr: Fix stale comment in TestRemovePendingConnection #1749

Merged
merged 1 commit into from Nov 10, 2021
Merged

connmgr: Fix stale comment in TestRemovePendingConnection #1749

merged 1 commit into from Nov 10, 2021

Conversation

sloorush
Copy link
Contributor

@sloorush sloorush commented Sep 6, 2021 •
edited

Changes the comment to

// Now examine the status of the connection request, it should read a 
// status of ConnCanceled.

This should resolve the confusion.

@coveralls
Copy link

coveralls commented Sep 13, 2021 •
edited

Pull Request Test Coverage Report for Build 1442430791

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 5 unchanged lines in 2 files lost coverage.
  • Overall coverage increased (+0.02%) to 52.991%
Files with Coverage Reduction New Missed Lines %
peer/peer.go 2 76.2%
btcec/signature.go 3 92.82%
Totals Coverage Status
Change from base Build 1385966408: 0.02%
Covered Lines: 21104
Relevant Lines: 39826
💛 - Coveralls

@sloorush
Copy link
Contributor Author

Please check it out @Roasbeef 😅

@jcvernaleo
Copy link
Member

@sloorush could you rebase this on master? Looks good and I'll merge, but it needs the rebase to pass the tests.

@jcvernaleo jcvernaleo self-assigned this Nov 9, 2021
@jcvernaleo jcvernaleo self-requested a review November 9, 2021 14:53
@sloorush
Copy link
Contributor Author

@jcvernaleo I have rebased it.

jcvernaleo
jcvernaleo approved these changes Nov 10, 2021
View reviewed changes
Copy link
Member

@jcvernaleo jcvernaleo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK

@jcvernaleo
Copy link
Member

Thanks, looks good now. Merging.

@jcvernaleo jcvernaleo merged commit 65e9868 into btcsuite:master Nov 10, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jcvernaleo jcvernaleo jcvernaleo approved these changes

Assignees

@jcvernaleo jcvernaleo

Labels
documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

connmgr: Stale comment in TestRemovePendingConnection
3 participants
@sloorush @coveralls @jcvernaleo