mempool: introduce GetDustThreshold to export dust limit calculation #1742
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit modifies no behavior and would allow other projects to retrieve the dust limit for a particular output type before the amount of the output is known. This is particularly useful in the Lightning Network for channel negotiation.
Pull Request Test Coverage Report for Build 1136251577
💛 - Coveralls |
|
I just forced github to rerun the failing tests in case it was just a fluke. If the tests fail again, could you take a look at them before we review? |
|
@jcvernaleo the tests pass locally on my machine, looking at the CI the failures seem unrelated |
Roasbeef
reviewed
Aug 18, 2021
| @@ -253,6 +246,20 @@ func IsDust(txOut *wire.TxOut, minRelayTxFee btcutil.Amount) bool { | |||
| totalSize += 107 | |||
| } | |||
|
|
|||
| return 3 * int64(totalSize) | |||
There was a problem hiding this comment.
Why is the factor of 3 here retained? When in the original dust calculation, this value is used to ensure that the amount spent on fees to spend an output isn't greater than 1/3 of the relay fee.
There was a problem hiding this comment.
Ah ok, we chatted offline and derived why this is in place.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit modifies no behavior and would allow other projects to retrieve the dust limit for a particular output type before the amount of the output is known (so
IsDustwouldn't be possible). This is particularly useful in the Lightning Network for channel negotiation. I did not include a unit test but I did locally check the following dust limits at the current 3000sat/kvb dust relay feerate: