txscript: optimize IsUnspendable by removing all allocations #1375
Conversation
During my work to optimize the IBD of btcd, I've been profiling heavily. I've noticed that this call `IsUnspendable` shows up in several hot spots during block validation, as we need to know if we should add a UTXO to the view/cache, etc. The current version uses `parseScript` to parse out all the pops and such. This is nice when we want to be able to easily manipulate things like data pushes, but for this simple check, it's unnecessary. The new version simply makes checks against the raw script which saves us a ton of allocations and CPU cycles.
|
While I completely agree with the concept of this PR (in fact I'd ultimately like to see much less parsing of the scripts into pops in general), this is a change to the semantics and would result in entries that can't be parsed being admitted to the utxo set. Any attempts to spend them would fail, so it shouldn't be a problem from a standpoint of consensus, but still not entirely desirable. Perhaps it would make sense to add an I believe a function like that would be useful for more than just this. |
|
@jcvernaleo (as per #1530)
|
|
No longer needed anymore due to #1769 |
During my work to optimize the IBD of btcd, I've been profiling heavily.
I've noticed that this call
IsUnspendableshows up in several hotspots during block validation, as we need to know if we should add a
UTXO to the view/cache, etc. The current version uses
parseScripttoparse out all the pops and such. This is nice when we want to be able to
easily manipulate things like data pushes, but for this simple check,
it's unnecessary. The new version simply makes checks against the raw
script which saves us a ton of allocations and CPU cycles.