This repository has been archived by the owner on Jan 8, 2020. It is now read-only.
Pluggable partition assignment strategies #218
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@pd thanks, but it will take a little bit longer to review this (due to other commitments). I will try to do a first round in the next few days. |
This is closer to the behavior of Kafka's Java consumer, as described here: https://github.com/apache/kafka/blob/15bc405/clients/src/main/java/org/apache/kafka/clients/consumer/RoundRobinAssignor.java#L31-L55 This is valuable in situations where you have highly disparate partition counts. Given three group members subscribed to many topics, only a few of which have more than one partition, the first member will receive far more assignments than the others.
This incorporates the round robin changes from bsm#216 (a64a8be) and exposes the ability for users to implement their own partition assignor. The tests for the two assignors now match the Java consumer's, to validate that the behaviors match up as expected. Reviewing the previous tests, I _think_ all of the same scenarios are still covered, as well. Backwards compatibility is maintained by falling back to the value in `PartitionStrategy` if the `PartitionAssignor` is unset.
|
I am currently working on the integration of a low level consumer group into sarama, see here: IBM/sarama#1083. The next release of sarama-cluster will use it. It comes with a BalanceStrategy interface which is what you are looking for. Feedback, if any, would be much appreciated. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This incorporates the round robin changes from #216 (a64a8be) and
exposes the ability for users to implement their own partition assignor.
See the previous PR for more information on the round robin changes.
The tests for the two assignors now match the Java consumer's, to
validate that the behaviors match up as expected. Reviewing the
previous tests, I think all of the same scenarios are still
covered, as well.
Backwards compatibility is maintained by falling back to the value in
PartitionStrategyif thePartitionAssignoris unset.