Add update-browserslist-db mention on --update-db call and deprecation hint. #791
Conversation
The --update-db key is missing in the usage hint printed to the terminal when CLI is called with the --help key.
|
We don’t have This is why we removed it from docs. Do you know how we can mention it in another way? |
|
But As I understand, |
I fixed the warning browserslist/update-db@3fff4d6 But are you sure that this warning was not from Browserslist? |
|
About 75% sure =). I did the repository search in GitHub and haven't found any string containing |
|
Since we fixed warning there. Can we close it or do you have maybe another idea what to add to docs here? |
|
Probably, add a hint when browserslist is called with That's the last idea I have. |
|
Yes, I like it. Can you send PR? :) |
|
Sure |
And rollback the --update-db print in the help hint.
konclave
changed the title
konclave
changed the title
|
done |
| @@ -38,6 +38,8 @@ if (isArg('--help') || isArg('-h')) { | |||
| } else if (isArg('--version') || isArg('-v')) { | |||
| process.stdout.write('browserslist ' + pkg.version + '\n') | |||
| } else if (isArg('--update-db')) { | |||
| process.stdout.write('The --update-db command is deprecated. Please use npx update-browserslist-db@latest instead.\n') | |||
| process.stdout.write('Browserslist DB update will still be made.\n') | |||
| /* c8 ignore next 3 */ | |||
There was a problem hiding this comment.
Can you just move this lines above and increase 3 to 5
There was a problem hiding this comment.
As you merged it, I won't make any following changes.
The --update-db key is missing in the usage hint printed to the terminal when CLI is called with the --help key.