Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add last N node versions (with major) support #671

Merged
merged 3 commits into from Mar 6, 2022
Merged
Show file tree
Hide file tree
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
3 changes: 3 additions & 0 deletions grammar.w3c-ebnf
Expand Up @@ -46,6 +46,8 @@ LastBrowsers ::= 'last' Space+ Digit+ Space+ (BrowserName Space+)? ('major' Spac

LastElectron ::= 'last' Space+ Digit+ Space+ 'electron' Space+ ('major' Space+)? VersionKeyword

LastNode ::= 'last' Space+ Digit+ Space+ 'node' Space+ ('major' Space+)? VersionKeyword

Unreleased ::= 'unreleased' Space+ ((BrowserName | 'electron') Space+)? VersionKeyword

Years ::= 'last' Space+ Numeric Space+ 'year' 's'?
Expand Down Expand Up @@ -96,6 +98,7 @@ Dead ::= 'dead'

QueryAtom ::= LastBrowsers
| LastElectron
| LastNode
| Unreleased
| Years
| Since
Expand Down
21 changes: 21 additions & 0 deletions index.js
Expand Up @@ -716,6 +716,19 @@ var QUERIES = [
})
}
},
{
regexp: /^last\s+(\d+)\s+node\s+major\s+versions?$/i,
select: function (context, versions) {
return getMajorVersions(
jsReleases.map(function (release) {
return release.version
}),
versions
).map(function (version) {
return 'node ' + version
})
}
},
{
regexp: /^last\s+(\d+)\s+(\w+)\s+major\s+versions?$/i,
select: function (context, versions, name) {
Expand All @@ -738,6 +751,14 @@ var QUERIES = [
})
}
},
{
regexp: /^last\s+(\d+)\s+node\s+versions?$/i,
select: function (context, versions) {
return jsReleases.slice(-versions).map(function (release) {
return 'node ' + release.version
})
}
},
{
regexp: /^last\s+(\d+)\s+(\w+)\s+versions?$/i,
select: function (context, versions, name) {
Expand Down
8 changes: 8 additions & 0 deletions test/node.test.js
Expand Up @@ -343,4 +343,12 @@ test('supports range selection', () => {
)
})

test('supports last versions for Node.js', () => {
is(browserslist('last 2 node versions').length >= 1, true)
})

test('supports last major versions for Node.js', () => {
is(browserslist('last 2 node major versions').length >= 1, true)
g-plane marked this conversation as resolved.
Show resolved Hide resolved
})

test.run()