Skip to content

Commit

Permalink
refactor: rename toChromium to byEngine
Browse files Browse the repository at this point in the history
  • Loading branch information
ylemkimon committed Jul 28, 2020
1 parent dfdf987 commit ca047f9
Show file tree
Hide file tree
Showing 4 changed files with 6 additions and 6 deletions.
4 changes: 2 additions & 2 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -521,8 +521,8 @@ Options:
data only about the latest version. Default is `false`.
* `normalizers`: An array of names of normalizers below and functions
that accept a browser and return the normalized versions, which are
applied to resolved browsers in order. For instance, `['toChromium', 'toDesktop']`.
* `toChromium`: Normalize Chromium-based browsers to Chrome. For instance,
applied to resolved browsers in order. For instance, `['byEngine', 'toDesktop']`.
* `byEngine`: Normalize Chromium-based browsers to Chrome. For instance,
UC Browser, QQ Browser, Baidu browser for Android, and Samsung Internet
will return `and_chr` with the version of Chromium they are based on.
Note Edge and Opera is not normalized. Gecko-based browsers are
Expand Down
2 changes: 1 addition & 1 deletion cli.js
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@ var USAGE = 'Usage:\n' +
' npx browserslist --env="environment name defined in config"\n' +
' npx browserslist --stats="path/to/browserlist/stats/file"\n' +
' npx browserslist --mobile-to-desktop\n' +
' npx browserslist --normalizers=toChromium,toDesktop\n' +
' npx browserslist --normalizers=byEngine,toDesktop\n' +
' npx browserslist --keep-original\n' +
' npx browserslist --update-db'

Expand Down
2 changes: 1 addition & 1 deletion index.js
Original file line number Diff line number Diff line change
Expand Up @@ -1201,7 +1201,7 @@ var QUERIES = [
]

var NORMALIZERS = {
toChromium: function (browser) {
byEngine: function (browser) {
var major = browser.split('.')[0]
var normalized = browserslist.normalizedVersions[major]
if (!normalized) {
Expand Down
4 changes: 2 additions & 2 deletions test/normalizer.test.js
Original file line number Diff line number Diff line change
Expand Up @@ -53,14 +53,14 @@ it('does not normalize classic Android webview versions', () => {
})

it('normalizes Chromium-based browsers to Chrome', () => {
let opts = { normalizers: ['toChromium'] }
let opts = { normalizers: ['byEngine'] }
expect(browserslist('samsung 4', opts)).toEqual(['and_chr 44'])
expect(browserslist('kaios 2.5', opts)).toEqual(['and_ff 48'])
expect(browserslist('and_chr 83', opts)).toEqual(['and_chr 83'])
})

it('should apply each normalizer in order', () => {
let opts = { normalizers: ['toChromium', 'toDesktop'] }
let opts = { normalizers: ['byEngine', 'toDesktop'] }
expect(browserslist('samsung 4', opts)).toEqual(['chrome 44'])
expect(browserslist('kaios 2.5', opts)).toEqual(['firefox 48'])
expect(browserslist('and_chr 83', opts)).toEqual(['chrome 83'])
Expand Down

0 comments on commit ca047f9

Please sign in to comment.