Normalize zero-padded version numbers #22
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Prevent exceptions in cases where version numbers have zero padded segments
|
@dsalahutdinov @ai I wonder if there's anyone who could review this PR? And there are a couple of other PRs that look like they should be merged too… |
|
Sorry, anyway we need @dsalahutdinov to release it |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prevent exceptions in cases where version numbers have zero padded segments.
I added a couple of test cases for user-agents that are known to contain zero padded segments. Namely the Chrome UA string from #8 and a UA string for Opera 12.