Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Server and client rendering for V2 site #287

Merged
merged 36 commits into from Jul 27, 2022
Merged

Server and client rendering for V2 site #287

merged 36 commits into from Jul 27, 2022

Conversation

sashachabin
Copy link
Collaborator

@sashachabin sashachabin commented Jul 26, 2022

Server

  • Browserslist query with caniuse-lite stats
  • Regionable browser stats

Client

  • Render example
  • client/__fixtures folder with test JSON data (temporary for dev)

Static data

  • Browsers icons from v1. 19 browsers + node.js Without Chrome Canary, FF beta etc., it's grouped with stable versions of browsers (design)
  • Wikipedia URLs

TODO

Plan to add for MVP

Questions

Pure Node.js best practices
You can help me by suggesting good examples of node.js servers. Perhaps I should make a classic MVC application (with folders routes, controllers, models, middlewares etc.). Or, maybe, it's too much for 2-3 entry points. :)

Deploy
What about Vercel? It seems to have been used before.
Vercel: Browserslist server code example, Response demo. Github Action Example with branches deploy

@sashachabin sashachabin requested review from ai and ariarzer July 26, 2022 10:44
@sashachabin sashachabin changed the title Server for V2 site Server for V2 site, static data Jul 26, 2022
@sashachabin sashachabin changed the title Server for V2 site, static data Server for V2 site Jul 26, 2022
browsers-data/icons/and_chr.png Outdated Show resolved Hide resolved
client/view/browsers/index.js Outdated Show resolved Hide resolved
server/index.js Outdated Show resolved Hide resolved
server/index.js Outdated Show resolved Hide resolved
server/index.js Outdated Show resolved Hide resolved
server/index.js Outdated Show resolved Hide resolved
@sashachabin sashachabin force-pushed the v2-server branch 2 times, most recently from d4f2fe6 to bb6fabb Compare July 27, 2022 12:41
@sashachabin sashachabin changed the title Server for V2 site Server and client rendering for V2 site Jul 27, 2022
server/index.js Show resolved Hide resolved
Output server errors in JSON { message: ... }
@ai ai merged commit 6cb1dd2 into v2 Jul 27, 2022
@ai ai deleted the v2-server branch July 27, 2022 16:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants