New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Server and client rendering for V2 site #287
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ai
reviewed
Jul 27, 2022
ai
reviewed
Jul 27, 2022
ai
reviewed
Jul 27, 2022
ai
reviewed
Jul 27, 2022
ai
reviewed
Jul 27, 2022
ai
reviewed
Jul 27, 2022
ai
reviewed
Jul 27, 2022
sashachabin
force-pushed
the
v2-server
branch
2 times, most recently
from
July 27, 2022 12:41
d4f2fe6
to
bb6fabb
Compare
sashachabin
changed the title
Server for V2 site
Server and client rendering for V2 site
Jul 27, 2022
ai
reviewed
Jul 27, 2022
Output server errors in JSON { message: ... }
ai
reviewed
Jul 27, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Server
Client
client/__fixtures
folder with test JSON data (temporary for dev)Static data
TODO
Plan to add for MVP
/social
endpoint with data{ githubStars, twitterFolowers }
node > *
queries support[BUG] App crash if "Region not found"— Throw errors on wrong feature and region names from Can I Use browserslist#714Questions
Pure Node.js best practices
You can help me by suggesting good examples of node.js servers. Perhaps I should make a classic MVC application (with folders routes, controllers, models, middlewares etc.). Or, maybe, it's too much for 2-3 entry points. :)
Deploy
What about Vercel? It seems to have been used before.
Vercel: Browserslist server code example, Response demo. Github Action Example with branches deploy