Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: implement getRandomValues and randomUUID - resolves #213 and #214 #215

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

markhughes
Copy link

@markhughes markhughes commented May 4, 2022

@Gambitboy
Copy link

Any update on getting this merged or looked at?

@brunomacf
Copy link

Any updates? This is important so we can try replace react-native-crypto by crypto-browserify.

@markhughes
Copy link
Author

markhughes commented Jun 23, 2022

unsure about the status of crypto-browserify, I think the project is not maintained TBH. Happy to help maintain if current maintainers are inactive?

@3cp
Copy link

3cp commented Jun 30, 2022

@markhughes do you want to maintain a fork? I will be one of many who are interested to use.

@Gambitboy
Copy link

@jprichardson , @calvinmetcalf , @ForbesLindesay or @fanatid any assistance?

@fanatid
Copy link

fanatid commented Jul 3, 2022

Hi, two things:

  • can you move tape update to another PR?
  • is it possible to leave links to node source code for verification that everything is the same?

Thanks!

@eggplantzzz
Copy link

eggplantzzz commented Jul 14, 2022

Just stopping by to say I would also be eager to see getRandomValues implemented in this library! Thanks @markhughes!

@markhughes
Copy link
Author

Sorry I will fix this PR up later this week, I've been sick and in-out of hospital

@shmillar
Copy link

Hello @markhughes , any updates on adding randomUUID() to crypto-browserify?

@BenGu3
Copy link

BenGu3 commented Feb 17, 2023

Also curious about when (if 😅) this will be merged in

@markhughes
Copy link
Author

markhughes commented Feb 20, 2023

Hi @fanatid sorry for the delay I've been dealing with some health issues!

can you move tape update to another PR?

Got it out of here, thanks. Not sure how that one snuck in but it was required to run on my computer.

is it possible to leave links to node source code for verification that everything is the same?

Perhaps just the specs?

Edit: which matches

@markhughes
Copy link
Author

Hey @fanatid, @jprichardson, @calvinmetcalf, @ForbesLindesay, @dcousens - you seem like the more recent past contributors in the browserify package. Could we possibly look at this?

@dcousens dcousens self-assigned this Jul 19, 2023
@jhenriquez
Copy link

Any updates? Is there an alternative package anyone is using?

CC: @markhughes @dcousens

@markhughes
Copy link
Author

It just needs to be merged. I'm using it for my own projects, but I don't think browserify is maintained like it used to be

@jhenriquez-ax
Copy link

Thank you @markhughes, doesn’t seem that anyone is maintaining the library. We forked yours so we can use it indefinitely.

Hopefully someone will take over maintenance here. This library is a recommended webpack 5 polyfill.

@ljharb ljharb mentioned this pull request Nov 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet